tillrohrmann commented on a change in pull request #10364:
[FLINK-14993][metrics] FrontMetricGroup passes reporter-specific parameters
URL: https://github.com/apache/flink/pull/10364#discussion_r354947838
##########
File path:
flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/metrics/jmx/JMXReporterTest.java
##########
@@ -130,10 +130,10 @@ public Integer getValue() {
};
rep1.notifyOfAddedMetric(g1, "rep1", new FrontMetricGroup<>(
- new ReporterScopedSettings(0),
+ new ReporterScopedSettings(0, '.'),
Review comment:
we could have a testing factory method for the `ReporterScopedSettings`.
Then we have a single place where the `ReporterScopedSettings` are being
created. In the future, if we add more fields to it, then we have a single
place where to add the default values to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
