tillrohrmann commented on a change in pull request #10364:
[FLINK-14993][metrics] FrontMetricGroup passes reporter-specific parameters
URL: https://github.com/apache/flink/pull/10364#discussion_r354946815
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -372,10 +374,10 @@ public void unregister(Metric metric, String metricName,
AbstractMetricGroup gro
if (reporters != null) {
for (int i = 0; i < reporters.size();
i++) {
try {
- MetricReporter reporter =
reporters.get(i);
- if (reporter != null) {
-
FrontMetricGroup front = new FrontMetricGroup<AbstractMetricGroup<?>>(i, group);
-
reporter.notifyOfRemovedMetric(metric, metricName, front);
+ ReporterAndSettings
reporterAndSettings = reporters.get(i);
+ if (reporterAndSettings
!= null) {
+
FrontMetricGroup front = new
FrontMetricGroup<AbstractMetricGroup<?>>(reporterAndSettings.settings, group);
Review comment:
access to fields should be consistent in this class. I would suggest to go
with `getSettings` as this method was introduced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
