zentol commented on a change in pull request #10460: [FLINK-14574] Fixing
writing with plugin s3 filesystem.
URL: https://github.com/apache/flink/pull/10460#discussion_r355047346
##########
File path: flink-end-to-end-tests/test-scripts/test_streaming_file_sink.sh
##########
@@ -44,14 +43,17 @@ if [ "${OUT_TYPE}" == "local" ]; then
elif [ "${OUT_TYPE}" == "s3" ]; then
echo "Use s3 output"
JOB_OUTPUT_PATH=${S3_OUTPUT_PATH}
+ set_config_key "state.checkpoints.dir"
"s3://$IT_CASE_S3_BUCKET/$S3_PREFIX-chk"
+ mkdir -p "$OUTPUT_PATH-chk"
else
echo "Unknown output type: ${OUT_TYPE}"
exit 1
fi
# make sure we delete the file at the end
function out_cleanup {
- s3_delete_by_full_path_prefix $OUT
+ s3_delete_by_full_path_prefix "$S3_PREFIX"
+ s3_delete_by_full_path_prefix "$S3_PREFIX-chk"
Review comment:
or clarity I'd prefer `${S3_PREFIX}-chk`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
