KurtYoung commented on a change in pull request #10454:
[FLINK-13195][sql-client] Add create(drop) table support for SqlClient
URL: https://github.com/apache/flink/pull/10454#discussion_r355093005
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -129,26 +132,50 @@
private StreamExecutionEnvironment streamExecEnv;
private Executor executor;
- public ExecutionContext(
+ // Members that should be reused in the same session.
+ @Nullable
+ private SessionState sessionState;
+
+ private ExecutionContext(
+ Environment environment,
+ SessionContext originalSessionContext,
+ List<URL> dependencies,
+ Configuration flinkConfig,
+ Options commandLineOptions,
+ List<CustomCommandLine> availableCommandLines) throws
FlinkException {
+ this(
+ environment,
+ originalSessionContext,
+ dependencies,
+ flinkConfig,
+ new DefaultClusterClientServiceLoader(),
+ commandLineOptions,
+ availableCommandLines);
+ }
+
+ private ExecutionContext(
Environment environment,
SessionContext originalSessionContext,
List<URL> dependencies,
Configuration flinkConfig,
+ ClusterClientServiceLoader clusterClientServiceLoader,
Review comment:
this field is not used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
