KurtYoung commented on a change in pull request #10454:
[FLINK-13195][sql-client] Add create(drop) table support for SqlClient
URL: https://github.com/apache/flink/pull/10454#discussion_r355093500
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -391,55 +431,119 @@ private static Executor lookupExecutor(
}
}
- private void initializeTableEnvironment() {
+ private void initializeTableEnvironment(SessionState sessionState) {
//--------------------------------------------------------------------------------------------------------------
// Step.1 Create environments
//--------------------------------------------------------------------------------------------------------------
+ createTableEnvironment(sessionState);
+
+ final boolean noInheritedState = sessionState == null;
+ if (noInheritedState) {
Review comment:
these initializations could happen when you create the `catalogManager`,
`moduleManager` and `functionCatalog`, around line 478-488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
