KurtYoung commented on a change in pull request #10452:
[FLINK-15035][table-planner-blink] Introduce unknown memory setting to table in
blink planner
URL: https://github.com/apache/flink/pull/10452#discussion_r355100944
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/HashAggCodeGenerator.scala
##########
@@ -60,7 +60,7 @@ class HashAggCodeGenerator(
AggCodeGenHelper.getAggBufferTypes(inputType, auxGrouping, aggregates)
private lazy val aggBufferRowType = RowType.of(aggBufferTypes.flatten,
aggBufferNames.flatten)
- def genWithKeys(reservedManagedMemory: Long)
+ def genWithKeys()
: GeneratedOperator[OneInputStreamOperator[BaseRow, BaseRow]] = {
Review comment:
no need to wrap line then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
