KurtYoung commented on a change in pull request #10452:
[FLINK-15035][table-planner-blink] Introduce unknown memory setting to table in
blink planner
URL: https://github.com/apache/flink/pull/10452#discussion_r355096112
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/utils/ExecutorUtils.java
##########
@@ -76,13 +75,9 @@ public static void
setBatchProperties(StreamExecutionEnvironment execEnv, TableC
* Sets batch properties for {@link StreamGraph}.
*/
public static void setBatchProperties(StreamGraph streamGraph,
TableConfig tableConfig) {
- // All transformations should set managed memory size.
- ResourceSpec managedResourceSpec =
NodeResourceUtil.fromManagedMem(0);
- streamGraph.getStreamNodes().forEach(sn -> {
- if (sn.getMinResources().equals(ResourceSpec.DEFAULT)) {
- sn.setResources(managedResourceSpec,
managedResourceSpec);
- }
- });
+ // using unknown mode!
Review comment:
useless comment..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
