zhijiangW commented on a change in pull request #10496: [FLINK-15153]Service
selector needs to contain jobmanager component label
URL: https://github.com/apache/flink/pull/10496#discussion_r355865915
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -108,17 +101,31 @@ public String getClusterDescription() {
@Override
public ClusterClientProvider<String> retrieve(String clusterId) {
- return createClusterClientProvider(clusterId);
+ final ClusterClientProvider<String> clusterClientProvider =
createClusterClientProvider(clusterId);
+
+ try (ClusterClient<String> clusterClient =
clusterClientProvider.getClusterClient()) {
Review comment:
I think the behavior is changed here. The previous way would not close the
`clusterClient`, but now we close the client after logging. If so it should not
be a hotfix commit and might need a unit test to cover the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
