zhijiangW commented on a change in pull request #10496: [FLINK-15153]Service
selector needs to contain jobmanager component label
URL: https://github.com/apache/flink/pull/10496#discussion_r355869144
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/ServiceDecorator.java
##########
@@ -89,7 +90,13 @@ protected Service decorateInternalResource(Service
resource, Configuration flink
}
spec.setPorts(servicePorts);
- spec.setSelector(resource.getMetadata().getLabels());
+
+ final Map<String, String> labels = new LabelBuilder()
Review comment:
`decorateInternalResource` is only used for job manager?
I think we should add a unit test for covering the changes if it is really a
bug. I mean before the changes the test should fail, and after this change it
can success. Otherwise we can not measure what is the difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
