wangyang0918 commented on a change in pull request #10496: [FLINK-15153]Service
selector needs to contain jobmanager component label
URL: https://github.com/apache/flink/pull/10496#discussion_r355870584
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/ServiceDecorator.java
##########
@@ -89,7 +90,13 @@ protected Service decorateInternalResource(Service
resource, Configuration flink
}
spec.setPorts(servicePorts);
- spec.setSelector(resource.getMetadata().getLabels());
+
+ final Map<String, String> labels = new LabelBuilder()
Review comment:
I have update the test `testCreateInternalService` and
`testCreateRestService` to verify the expected selector labels. Jobmanager
component label should exist.
If you revert the change of `ServiceDecorator`, the updated tests will fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
