wangyang0918 commented on a change in pull request #10496: [FLINK-15153]Service
selector needs to contain jobmanager component label
URL: https://github.com/apache/flink/pull/10496#discussion_r355871124
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesCliOptions.java
##########
@@ -46,15 +44,16 @@ public static Option getOptionWithPrefix(Option option,
String shortPrefix, Stri
.longOpt("clusterId")
.required(false)
.hasArg(true)
-
.desc(KubernetesConfigOptions.CLUSTER_ID.description().toString())
+ .desc("The cluster id that will be used for flink cluster. If
it's not set, the client will generate " +
+ "a random UUID name.")
.build();
public static final Option IMAGE_OPTION = Option.builder("i")
.longOpt("image")
.required(false)
.hasArg(true)
.argName("image-name")
-
.desc(KubernetesConfigOptions.CONTAINER_IMAGE.description().toString())
+ .desc("Image to use for Flink containers")
Review comment:
`KubernetesConfigOptions.CONTAINER_IMAGE.description().toString()` will get
`org.apache.flink.configuration.description.Description@166fa74d`, not the real
description.
The cli option description may be different with config option. So i just
put the real description text here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
