shuttie commented on issue #10529: [FLINK-15171] [serialization] fix performance regression caused by too many buffer allocations on string serialization URL: https://github.com/apache/flink/pull/10529#issuecomment-564508515 And the problematic flink-benchmarks: ``` 1 thread with-fix SerializationFrameworkMiniBenchmarks.serializerTuple thrpt 50 628.377 ± 14.407 ops/ms 1 thread no-fix SerializationFrameworkMiniBenchmarks.serializerTuple thrpt 50 628.152 ± 11.835 ops/ms 8 thread with-fix SerializationFrameworkMiniBenchmarks.serializerTuple thrpt 50 451.422 ± 5.737 ops/ms 8 thread no-fix SerializationFrameworkMiniBenchmarks.serializerTuple thrpt 50 450.485 ± 6.710 ops/ms 16 thread with-fix SerializationFrameworkMiniBenchmarks.serializerTuple thrpt 50 260.823 ± 4.057 ops/ms 16 thread no-fix SerializationFrameworkMiniBenchmarks.serializerTuple thrpt 50 190.611 ± 2.663 ops/ms ``` so if you stress the GC hard enough, it will start interfering with the benchmark code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
