zentol commented on a change in pull request #10482: [Flink-11956] Unshade s3
filesystems
URL: https://github.com/apache/flink/pull/10482#discussion_r356791557
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -108,83 +107,6 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
-
- <!-- Relocate all S3 related classes -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
Review comment:
without the shade configuration this module in itself shouldn't exist; and
should instead be a parent module for the other S3 filesystems containing the
current dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
