zentol commented on a change in pull request #10482: [Flink-11956] Unshade s3 filesystems URL: https://github.com/apache/flink/pull/10482#discussion_r356793801
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -108,83 +107,6 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
-
- <!-- Relocate all S3 related classes -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <executions>
- <execution>
- <id>shade-flink</id>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
-
<shadeTestJar>false</shadeTestJar>
- <artifactSet>
- <includes>
-
<include>*:*</include>
- </includes>
- </artifactSet>
- <relocations>
- <!-- shade
dependencies internally used by Hadoop and never exposed downstream -->
- <relocation>
-
<pattern>org.apache.commons</pattern>
-
<shadedPattern>org.apache.flink.fs.shaded.hadoop3.org.apache.commons</shadedPattern>
- </relocation>
-
- <!-- shade
dependencies internally used by AWS and never exposed downstream -->
- <relocation>
-
<pattern>software.amazon</pattern>
-
<shadedPattern>org.apache.flink.fs.s3base.shaded.software.amazon</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>org.joda</pattern>
-
<shadedPattern>org.apache.flink.fs.s3base.shaded.org.joda</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>org.apache.http</pattern>
-
<shadedPattern>org.apache.flink.fs.s3base.shaded.org.apache.http</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>com.fasterxml</pattern>
-
<shadedPattern>org.apache.flink.fs.s3base.shaded.com.fasterxml</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>com.google</pattern>
-
<shadedPattern>org.apache.flink.fs.s3base.shaded.com.google</shadedPattern>
- </relocation>
-
- <!-- shade
Flink's Hadoop FS adapter classes -->
- <relocation>
-
<pattern>org.apache.flink.runtime.fs.hdfs</pattern>
-
<shadedPattern>org.apache.flink.fs.s3.common.hadoop</shadedPattern>
- </relocation>
- </relocations>
- <filters>
- <filter>
-
<artifact>org.apache.flink:flink-hadoop-fs</artifact>
-
<excludes>
-
<exclude>org/apache/flink/runtime/util/HadoopUtils</exclude>
-
<exclude>org/apache/flink/runtime/fs/hdfs/HadoopRecoverable*</exclude>
-
</excludes>
- </filter>
- <filter>
-
<artifact>*</artifact>
-
<excludes>
-
<exclude>.gitkeep</exclude>
-
<exclude>mime.types</exclude>
-
<exclude>mozilla/**</exclude>
-
<exclude>META-INF/maven/**</exclude>
Review comment:
these filter should be propagated to the actual s3 filesystem modules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
