tillrohrmann opened a new pull request #10555: [FLINK-15013] Fix non local slot selection and root slot resolution URL: https://github.com/apache/flink/pull/10555 ## What is the purpose of the change This PR fixes two problems related to Flink's scheduling: In order to prevent a race condition where Executions are scheduled because their inputs' locations have been assigned but the underlying root slot not being marked as resolved and, hence, not being available for location based scheduling, this commit enforces that we first resolve the root slot before completing the associated MultiTaskSlot. The LocationPreferenceSlotSelectionStrategy ignored NON_LOCAL slots due to initializing the initial candidate score to a positive value. As NON_LOCAL candidates have a value of 0, the initial candidate score needs to be negative, otherwise NON_LOCAL candidates will be ignored. ## Verifying this change - Added `LocationPreferenceSlotSelectionStrategyTest#returnsNonLocalMatchingIfResourceProfileCanBeFulfilledButNotTheTMLocationPreferences` and `SlotSharingManagerTest#shouldResolveRootSlotBeforeCompletingChildSlots`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
