wuchong commented on a change in pull request #10536: [FLINK-15191][connectors
/ kafka]Fix can't create table source for Kafka if watermark or computed column
is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r357499765
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchUpsertTableSinkBase.java
##########
@@ -165,7 +166,7 @@ public void setIsAppendOnly(Boolean isAppendOnly) {
@Override
public TypeInformation<Row> getRecordType() {
- return schema.toRowType();
+ return
TableSchemaUtils.filterGeneratedColumn(schema).toRowType();
Review comment:
This is still problematic. The table sink should carry the true **physical**
schema. Otherwise, for example, if `getTableSchema` returns generated columns,
the planner will fail in some cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
