wuchong commented on a change in pull request #10536: [FLINK-15191][connectors
/ kafka]Fix can't create table source for Kafka if watermark or computed column
is defined.
URL: https://github.com/apache/flink/pull/10536#discussion_r358043306
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkBase.java
##########
@@ -67,7 +68,7 @@ protected KafkaTableSinkBase(
Properties properties,
Optional<FlinkKafkaPartitioner<Row>> partitioner,
SerializationSchema<Row> serializationSchema) {
- this.schema = Preconditions.checkNotNull(schema, "Schema must
not be null.");
+ this.schema =
Preconditions.checkNotNull(TableSchemaUtils.getPhysicalTableSchema(schema),
"Schema must not be null.");
Review comment:
check not null before call `getPhysicalTableSchema`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
