Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-156469184
Hi @gallenvara, I read your PR and have some comments.
First, since Flink 0.10, we dropped Java 6 support and can use omit types
if the types can be inferred. So could you remove type description in that
case? With removing, we can make codes more readable.
Second, to convert Scala sequence to Java list, using `JavaConverters` is
better than `JavaConversions`. For example:
```scala
import scala.collection.JavaConverters._
~skipped~
val result = ds.collect()
val expected = "~~~"
TestBaseUtils.compareResultAsText(result.asJava, expected)
```
After importing `scala.collection.JavaConverters._`, we can convert Scala
collection to Java collection with `asJava` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
