Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1349#discussion_r45545495
--- Diff:
flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/CastingITCase.java
---
@@ -44,29 +41,13 @@ public CastingITCase(TestExecutionMode mode){
super(mode);
}
- private String resultPath;
- private String expected = "";
-
- @Rule
- public TemporaryFolder tempFolder = new TemporaryFolder();
-
- @Before
- public void before() throws Exception{
- resultPath = tempFolder.newFile().toURI().toString();
- }
-
- @After
- public void after() throws Exception{
- compareResultsByLinesInMemory(expected, resultPath);
- }
-
@Test
public void testAutoCastToString() throws Exception {
ExecutionEnvironment env =
ExecutionEnvironment.getExecutionEnvironment();
TableEnvironment tableEnv = new TableEnvironment();
DataSource<Tuple7<Byte, Short, Integer, Long, Float, Double,
String>> input =
- env.fromElements(new Tuple7<Byte, Short,
Integer, Long, Float, Double, String>(
+ env.fromElements(new Tuple7<>(
(byte) 1, (short) 1, 1, 1L,
1.0f, 1.0d, "Hello"));
--- End diff --
I think merging L51 and L50 would be better. After omitting generic
parameters, we don't need a newline for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
