tillrohrmann commented on a change in pull request #10646:
[FLINK-15320][runtime] Increment versions of all vertices when
failing/canceling/suspending a job
URL: https://github.com/apache/flink/pull/10646#discussion_r360835260
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -397,6 +407,18 @@ protected JobGraph getJobGraph() {
protected abstract long getNumberOfRestarts();
+ private Map<ExecutionVertexID, ExecutionVertexVersion>
incrementVersionsOfAllVertices() {
+ return executionVertexVersioner.recordVertexModifications(
+ IterableUtils.toStream(schedulingTopology.getVertices())
+ .map(SchedulingExecutionVertex::getId)
+ .collect(Collectors.toSet()));
+ }
+
+ @VisibleForTesting
+ ExecutionVertexVersioner getExecutionVertexVersioner() {
+ return executionVertexVersioner;
+ }
Review comment:
Can be removed, as we pass in the `executionVertexVersioner` and can keep a
reference to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
