[
https://issues.apache.org/jira/browse/FLINK-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006087#comment-15006087
]
ASF GitHub Bot commented on FLINK-3012:
---------------------------------------
Github user jaoki commented on the pull request:
https://github.com/apache/flink/pull/1355#issuecomment-156867821
@StephanEwen , thank you for your feedback. Looping with an int variable is
clearly wrong in Flink's use case, and I can change to long, but, I'd like to
hear more of this refactor. I'd withdraw this PR if it is not what the
community prefer at the first place. Let me know!
> Refactor boilerplate code of while and if statements in DataSourceTask
> ----------------------------------------------------------------------
>
> Key: FLINK-3012
> URL: https://issues.apache.org/jira/browse/FLINK-3012
> Project: Flink
> Issue Type: Improvement
> Reporter: jun aoki
> Priority: Trivial
>
> Part of DataSourceTask code seems repetitive.
> https://github.com/jaoki/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java#L153-L173
> The same 'while', 'if' and createInstance() shows up.
> This ticket to refactor it to avoid the boilerplate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
