[
https://issues.apache.org/jira/browse/FLINK-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006094#comment-15006094
]
ASF GitHub Bot commented on FLINK-3012:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1355#issuecomment-156869041
I'm not too fond of the new version either and feel like this code bit
doesn't really need more clarity, simply because it isn't a lot of code.
Using a counter at all doesn't really make sense to me, you aren't counting
anything effectively. a Boolean seems more intuitive. It is nit-picky but we
are going for clarity here after all :)
> Refactor boilerplate code of while and if statements in DataSourceTask
> ----------------------------------------------------------------------
>
> Key: FLINK-3012
> URL: https://issues.apache.org/jira/browse/FLINK-3012
> Project: Flink
> Issue Type: Improvement
> Reporter: jun aoki
> Priority: Trivial
>
> Part of DataSourceTask code seems repetitive.
> https://github.com/jaoki/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java#L153-L173
> The same 'while', 'if' and createInstance() shows up.
> This ticket to refactor it to avoid the boilerplate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
