danny0405 commented on a change in pull request #10680:
[FLINK-15125][table-planner-blink] PROCTIME() computed column defined…
URL: https://github.com/apache/flink/pull/10680#discussion_r361378847
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/BatchLogicalWindowAggregateRule.scala
##########
@@ -56,6 +57,10 @@ class BatchLogicalWindowAggregateRule
operand: RexNode,
windowExprIdx: Int,
rowType: RelDataType): FieldReferenceExpression = {
+ if (FlinkTypeFactory.isProctimeIndicatorType(operand.getType)) {
+ throw new ValidationException("Window can not be defined over "
+ + "a proctime attribute column for batch mode")
+ }
operand match {
// match TUMBLE_ROWTIME and TUMBLE_PROCTIME
Review comment:
I'm not sure either, @godfreyhe can you give some help ? Thanks for that :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
