wuchong commented on a change in pull request #10680: [FLINK-15125][table-planner-blink] PROCTIME() computed column defined… URL: https://github.com/apache/flink/pull/10680#discussion_r361380790
########## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/agg/WindowAggregateTest.scala ########## @@ -38,6 +39,11 @@ class WindowAggregateTest(aggStrategy: AggregatePhaseStrategy) extends TableTest private val util = batchTestUtil() + private val _expectedEx: ExpectedException = ExpectedException.none + + @Rule + def expectedEx: ExpectedException = _expectedEx Review comment: We don't need this. `TableTestBase` already have `thrown` method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
