zhijiangW commented on a change in pull request #10616: [FLINK-15288] Starting
jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361390648
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -640,4 +641,30 @@ public static String getDynamicProperties(Configuration
baseConfig, Configuratio
.toArray(String[]::new);
return String.join(" ", newAddedConfigs);
}
+
+ /**
+ * Calculate heap size after cut-off.
+ */
+ public static int calculateHeapSize(int memory,
org.apache.flink.configuration.Configuration conf) {
Review comment:
I am not quite sure whether this function is out of scope of the class. From
the definition of this class, it should not cover this function. Can you find
other proper places for this utility or we can define a new util class for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
