zhijiangW commented on a change in pull request #10616: [FLINK-15288] Starting
jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361400107
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/BootstrapToolsTest.java
##########
@@ -423,4 +425,60 @@ public void testGetDynamicProperties() {
String dynamicProperties =
BootstrapTools.getDynamicProperties(baseConfig, targetConfig);
assertEquals("-Dkey.b=b2 -Dkey.c=c", dynamicProperties);
}
+
+ /**
+ * Remove 15% of the heap, at least 384MB.
Review comment:
This description can not cover all the cases of this test. You can remove
the description completely or give a more precise one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services