xuefuz commented on a change in pull request #10625: [FLINK-15259][hive]
HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362146373
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java
##########
@@ -232,4 +233,10 @@ SimpleGenericUDAFParameterInfo
createUDAFParameterInfo(ObjectInspector[] params,
* Converts a hive date instance to LocalDate which is expected by
DataFormatConverter.
*/
LocalDate toFlinkDate(Object hiveDate);
+
+ /**
+ * Converts a Hive primitive java object to corresponding Writable
object. Throws CatalogException if the conversion
+ * is not supported.
+ */
+ Writable hivePrimitiveToWritable(Object value) throws CatalogException;
Review comment:
Throwing a catalog ex doesn't seem very intuitive, even though CatalogEx is
also a runtime exception. Maybe just remove CatalogEx from the signature and
throw a runtime exception when problem occurs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
