lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive]
HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362173968
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L,
${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
@xuefuz @JingsongLi This is a bug in planner when generating timestamp
literals: we pass the type instead of the value as the literal. The added test
exposes the issue. Do you think this change needs a dedicated PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
