GJL commented on a change in pull request #10666: [FLINK-15214] Introduce
multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362497483
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -629,15 +636,17 @@ function wait_oper_metric_num_in_records {
done
}
+function wait_num_of_occurence_in_logs_mesos() {
+ local text=$1
+ local number=$2
+ wait_num_of_occurence_in_logs $1 $2 "mesos-appmaster"
+}
+
function wait_num_of_occurence_in_logs {
local text=$1
local number=$2
local logs
- if [ -z "$3" ]; then
- logs="standalonesession"
- else
- logs="$3"
- fi
+ local logs=${3-standalonesession}
Review comment:
Very nice simplification.
nit: So far we have always used the `${3:-standalonesession}` syntax for
default values in this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
