GJL commented on a change in pull request #10666: [FLINK-15214] Introduce
multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363278340
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -456,14 +456,21 @@ function wait_job_running {
exit 1
}
+function wait_job_terminal_state_mesos {
+ local job=$1
+ local expected_terminal_state=$2
+ wait_job_terminal_state $1 $2 "mesos-appmaster"
+}
+
function wait_job_terminal_state {
local job=$1
local expected_terminal_state=$2
+ local log_file_name=${3:-standalonesession}
echo "Waiting for job ($job) to reach terminal state
$expected_terminal_state ..."
while : ; do
- local N=$(grep -o "Job $job reached globally terminal state .*"
$FLINK_DIR/log/*standalonesession*.log | tail -1 || true)
+ local N=$(grep -o "Job $job reached globally terminal state .*"
$FLINK_DIR/log/*$log_file_name*.log | tail -1 || true)
Review comment:
It's really a pity that we need a separate file pattern for the mesos
appmaster but fixing that would be outside the scope of this ticket. However, I
wonder if it makes sense to move the mesos flavored functions to a separate
file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
