[
https://issues.apache.org/jira/browse/FLINK-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008718#comment-15008718
]
ASF GitHub Bot commented on FLINK-2901:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1306#issuecomment-157382048
@fhueske I've addressed most of your concerns.
Things that still need work / clarification:
* PreviewPlanDumpTest was previously executed with 2 different sets of
arguments, now only with 1. Should this be changed back to the previous
behaviour? The arguments affect paths for sources/sink, parallelism and the
number of Iterations
* test.classloading.jar.KMeansForTest appears to be a good replacement for
the IterativeKMeansITCase, what's your take on that?
* The removed delta ilteration PageRank program looks very similar to the
ConnectedComponents implementation under flink-examples. I don't think this
needs a separate port.
> Several flink-test ITCases depend on Record API features
> --------------------------------------------------------
>
> Key: FLINK-2901
> URL: https://issues.apache.org/jira/browse/FLINK-2901
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 0.10.0
> Reporter: Fabian Hueske
> Assignee: Chesnay Schepler
>
> There are several ITCases and utility classes in {{flink-tests}} that depend
> on the Record API including:
> - ITCases for Record API operators in
> {{flink-tests/src/test/java/org/apache/flink/test/operators}}
> - ITCases for Record API programs in
> {{flink-tests/src/test/java/org/apache/flink/test/recordJobTests}}
> - Record API programs in
> {{flink-tests/src/test/java/org/apache/flink/test/recordJobs}}
> - Several ITCases for iterations in
> {{flink-tests/src/test/java/org/apache/flink/test/iterative}}
> - Tests for job canceling in
> {{flink-tests/src/test/java/org/apache/flink/test/cancelling}}
> - Test for failing jobs in
> {{flink-tests/src/test/java/org/apache/flink/test/failingPrograms/TaskFailureITCase}}
> - Optimizer tests in
> {{flink-tests/src/test/java/org/apache/flink/test/optimizer}}
> - Accumulator test in
> {{flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorIterativeITCase}}
> - Broadcast test in
> {{flink-tests/src/test/java/org/apache/flink/test/broadcastvasr/BroadcastBranchingITCase}}
> - distributed cache test in
> {{flink-tests/src/test/java/org/apache/flink/test/distributedCache/DistributedCacheTest}}
> and probably a few more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
