[
https://issues.apache.org/jira/browse/FLINK-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024211#comment-15024211
]
ASF GitHub Bot commented on FLINK-2901:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1306#issuecomment-159223361
Hi @zentol, sorry for the delayed review.
You are right, `DeltaPageRankITCase` (which executes for some reason the
Record API delta iteration ConnectedComponents example) is identical to the
DataSet `ConnectedComponentsITCase`. So we do not port this one.
I also agree to remove the checks for empty arguments in the
`PreviewPlanDumpTest`. This requires cooperation of the job, i.e., the job may
not fail for empty arguments, and tests exactly the same code paths as the
tests with arguments, as far as I see.
However, I do not think that the `ClassLoaderITCase` which calls the
`KMeansForTest` is a good replacement for the `IterativeKMeansITCase`. The
programs are identical but, the `ClassLoaderITCase` only checks if the program
executes without an error and does not check the result.
@zentol Is it OK for you if I add this one last test and merge this PR
afterwards?
> Several flink-test ITCases depend on Record API features
> --------------------------------------------------------
>
> Key: FLINK-2901
> URL: https://issues.apache.org/jira/browse/FLINK-2901
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 0.10.0
> Reporter: Fabian Hueske
> Assignee: Chesnay Schepler
>
> There are several ITCases and utility classes in {{flink-tests}} that depend
> on the Record API including:
> - ITCases for Record API operators in
> {{flink-tests/src/test/java/org/apache/flink/test/operators}}
> - ITCases for Record API programs in
> {{flink-tests/src/test/java/org/apache/flink/test/recordJobTests}}
> - Record API programs in
> {{flink-tests/src/test/java/org/apache/flink/test/recordJobs}}
> - Several ITCases for iterations in
> {{flink-tests/src/test/java/org/apache/flink/test/iterative}}
> - Tests for job canceling in
> {{flink-tests/src/test/java/org/apache/flink/test/cancelling}}
> - Test for failing jobs in
> {{flink-tests/src/test/java/org/apache/flink/test/failingPrograms/TaskFailureITCase}}
> - Optimizer tests in
> {{flink-tests/src/test/java/org/apache/flink/test/optimizer}}
> - Accumulator test in
> {{flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorIterativeITCase}}
> - Broadcast test in
> {{flink-tests/src/test/java/org/apache/flink/test/broadcastvasr/BroadcastBranchingITCase}}
> - distributed cache test in
> {{flink-tests/src/test/java/org/apache/flink/test/distributedCache/DistributedCacheTest}}
> and probably a few more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
