openinx commented on a change in pull request #10637: [FLINK-15319][e2e]
flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r363143736
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -102,13 +126,16 @@ public Path getOrDownload(final String url, final Path
targetDir) throws IOExcep
} else {
final Path scopedDownloadDir =
downloadsDir.resolve(String.valueOf(url.hashCode()));
Files.createDirectories(scopedDownloadDir);
- log.info("Downloading {}.", url);
+
+ long downloadTimeoutMillis = getDownloadTimeoutMillis();
+ int maxRetries = getDownloadMaxRetries();
+ log.info("Downloading {} with maxRetries={}, and
timeout of one retry is {} (ms).", url, maxRetries, downloadTimeoutMillis);
AutoClosableProcess
- .create(
- CommandLineWrapper.wget(url)
- .targetDir(scopedDownloadDir)
- .build())
- .runBlocking(Duration.ofMinutes(2));
+ .create(
Review comment:
The new indentation should be right here, so I think we can keep the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
