[
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009248#comment-15009248
]
ASF GitHub Bot commented on FLINK-2978:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1338#discussion_r45102455
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -302,6 +302,15 @@
*/
public static final String JOB_MANAGER_WEB_LOG_PATH_KEY =
"jobmanager.web.log.path";
+ /**
+ * Config parameter indicating whether jobs can be uploaded and run
from the web-frontend.
+ */
+ public static final String JOB_MANAGER_WEB_SUBMISSION_KEY =
"jobmanager.web.submit.allow";
--- End diff --
Think of a config as a JSON object. There is an object "jobmanager.web" and
it contains an object "submit" with a field "allow."
1) I think "enable" is better than "allow".
2) You have two different nested objects, called "submit" and "upload".
Since they refer to the same function, makes sense to fuse them, in my opinion.
> Integrate web submission interface into the new dashboard
> ---------------------------------------------------------
>
> Key: FLINK-2978
> URL: https://issues.apache.org/jira/browse/FLINK-2978
> Project: Flink
> Issue Type: New Feature
> Components: Web Client, Webfrontend
> Reporter: Sachin Goel
> Assignee: Sachin Goel
>
> As discussed in
> http://mail-archives.apache.org/mod_mbox/flink-dev/201511.mbox/%3CCAL3J2zQg6UBKNDnm=8tshpz6r4p2jvx7nrlom7caajrb9s6...@mail.gmail.com%3E,
> we should integrate job submission from the web into the dashboard.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
