[ 
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009273#comment-15009273
 ] 

ASF GitHub Bot commented on FLINK-2978:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1338#discussion_r45103976
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandler.java
 ---
    @@ -0,0 +1,253 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.webmonitor.handlers;
    +
    +import com.fasterxml.jackson.core.JsonGenerator;
    +import org.apache.flink.client.program.Client;
    +import org.apache.flink.client.program.PackagedProgram;
    +import org.apache.flink.client.program.ProgramInvocationException;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.optimizer.CompilerException;
    +import org.apache.flink.optimizer.DataStatistics;
    +import org.apache.flink.optimizer.Optimizer;
    +import org.apache.flink.optimizer.costs.DefaultCostEstimator;
    +import org.apache.flink.optimizer.plan.FlinkPlan;
    +import org.apache.flink.optimizer.plan.OptimizedPlan;
    +import org.apache.flink.optimizer.plan.StreamingPlan;
    +import org.apache.flink.optimizer.plantranslate.JobGraphGenerator;
    +import org.apache.flink.runtime.client.JobClient;
    +import org.apache.flink.runtime.client.JobExecutionException;
    +import org.apache.flink.runtime.instance.ActorGateway;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.jobgraph.jsonplan.JsonPlanGenerator;
    +import scala.concurrent.duration.FiniteDuration;
    +
    +import java.io.File;
    +import java.io.IOException;
    +import java.io.OutputStream;
    +import java.io.PrintStream;
    +import java.io.PrintWriter;
    +import java.io.StringWriter;
    +import java.net.URISyntaxException;
    +import java.net.URL;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * This handler handles requests to fetch plan for an already uploaded 
jar, as well as for
    + * running it.
    + */
    +public class JarActionHandler implements RequestHandler, 
RequestHandler.JsonResponse {
    +
    +   private final File jarDir;
    +
    +   private final boolean toRun;
    --- End diff --
    
    Two subclasses of an abstract class (one for Run, one for Plan) are nicer 
than a boolean flag that switches behavior.


> Integrate web submission interface into the new dashboard
> ---------------------------------------------------------
>
>                 Key: FLINK-2978
>                 URL: https://issues.apache.org/jira/browse/FLINK-2978
>             Project: Flink
>          Issue Type: New Feature
>          Components: Web Client, Webfrontend
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> As discussed in 
> http://mail-archives.apache.org/mod_mbox/flink-dev/201511.mbox/%3CCAL3J2zQg6UBKNDnm=8tshpz6r4p2jvx7nrlom7caajrb9s6...@mail.gmail.com%3E,
>  we should integrate job submission from the web into the dashboard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to