zhijiangW commented on issue #10736: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories URL: https://github.com/apache/flink/pull/10736#issuecomment-571553868 Thanks for this fix @gaoyunhaii ! The `FileChannelManagerImpl` would be used by both `IOManager` and `NettyShuffleEnvironment`. The `IOManager` already added the shutdown hook to close the files finally. I am wondering why can not add the shutdown hook to the `NettyShuffleEnvironment` instead of `FileChannelManagerImpl`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
