pnowojski commented on a change in pull request #10332:
[FLINK-13905][checkpointing] Separate checkpoint triggering into several
asynchronous stages
URL: https://github.com/apache/flink/pull/10332#discussion_r364201755
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -162,9 +162,9 @@
* Non-volatile, because only accessed in synchronized scope */
private boolean periodicScheduling;
- /** Flag whether a trigger request could not be handled immediately.
Non-volatile, because only
- * accessed in synchronized scope */
- private boolean triggerRequestQueued;
+ /** Flag whether periodic triggering is suspended (too many concurrent
pending checkpoint).
+ * Non-volatile, because only accessed in synchronized scope */
+ private boolean periodicTriggeringSuspended;
Review comment:
I'm mostly trying to figure out what's going on :) If there was an
information in the commit message whether this is a pure refactor or not (with
some list of functional changes), that would help me (and other people looking
at it in the future) understand the commit faster :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
