pnowojski commented on a change in pull request #10332:
[FLINK-13905][checkpointing] Separate checkpoint triggering into several
asynchronous stages
URL: https://github.com/apache/flink/pull/10332#discussion_r363289359
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -162,9 +162,9 @@
* Non-volatile, because only accessed in synchronized scope */
private boolean periodicScheduling;
- /** Flag whether a trigger request could not be handled immediately.
Non-volatile, because only
- * accessed in synchronized scope */
- private boolean triggerRequestQueued;
+ /** Flag whether periodic triggering is suspended (too many concurrent
pending checkpoint).
+ * Non-volatile, because only accessed in synchronized scope */
+ private boolean periodicTriggeringSuspended;
Review comment:
Ok, thanks for the extra context (this explanation I think also could be
added to this commit message). I was also confused/didn't like the previous
`triggerRequestQueued` name.
However I'm still missing if this commit changes any behaviour or is it just
pure rename/clean up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
