aljoscha commented on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-572122803 Sorry for the late response. I think the solution here is to add a method `verifyClientConnection(C client)` to `ElasticsearchApiCallBridge` and move the verification logic that the subclasses of `ElasticsearchApiCallBridge` have in `createClient(...)` to this new method. This way, the `ElasticsearchSinkBase` can always store the client in its internal field, making sure that the client will be closed when a failure happens.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
