xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible URL: https://github.com/apache/flink/pull/10829#issuecomment-574548126 @dawidwys Thanks for asking. What @tillrohrmann said sounds good to me. My only concern was that, as @tillrohrmann mentioned, it is more difficult to make sure always log MemorySize with some method other than `toString`. If we consider the approximate value as a special format that one should explicitly consent to, then it makes sense to me and I do not have other objections. +1 for merging this PR as MemorySize prints exact values in `toString`. I'll adjust mine #10785.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
