xintongsong commented on a change in pull request #10852:
[FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate
the original intended behavior
URL: https://github.com/apache/flink/pull/10852#discussion_r367209409
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -104,9 +104,7 @@ public void testFailIfTaskSlotsHigherThanMaxVcores()
throws ClusterDeploymentExc
clusterDescriptor.setLocalJarPath(new Path(flinkJar.getPath()));
ClusterSpecification clusterSpecification = new
ClusterSpecification.ClusterSpecificationBuilder()
- .setMasterMemoryMB(1)
- .setTaskManagerMemoryMB(1)
- .setNumberTaskManagers(1)
+ .setTaskManagerMemoryMB(1024)
Review comment:
I'll give it a try to change the default to 1024, see if it breaks anything.
I'm actually thinking about remove `ClusterSpecification` entirely. I've
visited all the usages of this class, and it seems to me all its information
can be fetched directly from configuration. However, I'd like to scope this out
from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
