azagrebin commented on a change in pull request #10852:
[FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate
the original intended behavior
URL: https://github.com/apache/flink/pull/10852#discussion_r367361636
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -318,6 +308,20 @@ private void isReadyForDeployment(ClusterSpecification
clusterSpecification) thr
}
}
+ @VisibleForTesting
+ protected int getNumYarnMaxVcores() throws YarnDeploymentException {
Review comment:
I also looked into `YarnClientImpl`. My only concern about this option was
that it is annotated with `@Private` and `@Unstable` but I did not see that we
actually already decided once to extend it. I would be ok with it. I guess we
will refactor it if this class is gone after updating the Yarn dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
