uce commented on a change in pull request #10510: [FLINK-15176][container] Add
'--job-classname' to flink-container 'jo…
URL: https://github.com/apache/flink/pull/10510#discussion_r368236896
##########
File path: flink-container/kubernetes/job-cluster-job.yaml.template
##########
@@ -31,7 +31,7 @@ spec:
containers:
- name: flink-job-cluster
image: ${FLINK_IMAGE_NAME}
- args: ["job-cluster", "-Djobmanager.rpc.address=flink-job-cluster",
+ args: ["job-cluster", "--job-classname=${JOB_CLASSNAME}",
"-Djobmanager.rpc.address=flink-job-cluster",
Review comment:
How is an empty string for `--job-classname` handled by the main method? If
it's ignored by choice and falls back to class path scanning, this could be ok.
Otherwise, I still think that making this required would hurt common case user
experience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
