godfreyhe opened a new pull request #10904: [FLINK-15669] [sql client] fix SQL client can't cancel flink job URL: https://github.com/apache/flink/pull/10904 ## What is the purpose of the change *reason: in sql client, CLI client do cancel query operaiton through void cancelQuery(String sessionId, String resultId) method in Executor. However, the resultId is a random UUID, is not the job id. solution: changes the non-blocking deployment to blocking deployment in LocalExecutor#executeQueryInternal method, and then we can get jobId from JobClient, and then use it as resultId. The parameter of DynamicResult#startRetrieval method should also be changed from ProgramDeployer to JobClient, like void startRetrieval(JobClient jobClient);* ## Brief change log - *changes the non-blocking deployment to blocking deployment in LocalExecutor#executeQueryInternal method* - *changes the DynamicResult#startRetrieval method's parameter from ProgramDeployer to JobClient * ## Verifying this change This change is verified by manual testing. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
