dawidwys opened a new pull request #10909: [FLINK-15686][sql-client] Use old type system in CollectStreamTableSink URL: https://github.com/apache/flink/pull/10909 ## What is the purpose of the change Fix mismatch between a declared logical schema with a declared physical schema of a `CollectStreamTableSink`. ## Brief change log - Do not pass around a `RowType` in sql-client as it contains duplicated information with `TableSchema` - Use legacy types in `CollectStreamTableSink#getTableSchema` via `CollectStreamTableSink#getFieldTypes` & `CollectStreamTableSink#getFieldNames` ## Verifying this change Extended tests in `LocalExecutorITCase` to include a problematic `CHAR(3)` coming from a string literal in a result of a query. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
