JingsongLi commented on a change in pull request #10909:
[FLINK-15686][sql-client] Use old type system in CollectStreamTableSink
URL: https://github.com/apache/flink/pull/10909#discussion_r368872147
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/CollectStreamTableSink.java
##########
@@ -43,21 +43,32 @@
private final TypeSerializer<Tuple2<Boolean, Row>> serializer;
private final TableSchema tableSchema;
- public CollectStreamTableSink(InetAddress targetAddress, int
targetPort, TypeSerializer<Tuple2<Boolean, Row>> serializer, TableSchema
tableSchema) {
+ public CollectStreamTableSink(
+ InetAddress targetAddress,
+ int targetPort,
+ TypeSerializer<Tuple2<Boolean, Row>> serializer,
+ TableSchema tableSchema) {
this.targetAddress = targetAddress;
this.targetPort = targetPort;
this.serializer = serializer;
this.tableSchema =
TableSchemaUtils.checkNoGeneratedColumns(tableSchema);
Review comment:
Sounds reasonable to me. I don't have a strong tendency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
