pnowojski commented on a change in pull request #10931: [FLINK-15603][metrics]
Add checkpointStartDelay metric
URL: https://github.com/apache/flink/pull/10931#discussion_r370089380
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierHandler.java
##########
@@ -95,4 +101,10 @@ protected void notifyAbortOnCancellationBarrier(long
checkpointId) throws Except
protected void notifyAbort(long checkpointId, CheckpointException
cause) throws Exception {
toNotifyOnCheckpoint.abortCheckpointOnBarrier(checkpointId,
cause);
}
+
+ protected void markCheckpointStart(long checkpointCreationTimestamp) {
+ latestCheckpointStartDelayNanos = 1000_000 * Math.max(
Review comment:
Whether it is in the name or not, I think is a secondary issue. If we
provide some stats, it's best if all have the same units.
https://ci.apache.org/projects/flink/flink-docs-stable/monitoring/metrics.html#checkpointing
however, annoying thing is, that in this class yes, all units are in nanos,
but in other places it's millis (7 metrics in millis vs 2 in nanos?). More
over, web ui is also using millis only...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
