pnowojski commented on a change in pull request #10931: [FLINK-15603][metrics]
Add checkpointStartDelay metric
URL: https://github.com/apache/flink/pull/10931#discussion_r370160682
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierHandler.java
##########
@@ -95,4 +101,10 @@ protected void notifyAbortOnCancellationBarrier(long
checkpointId) throws Except
protected void notifyAbort(long checkpointId, CheckpointException
cause) throws Exception {
toNotifyOnCheckpoint.abortCheckpointOnBarrier(checkpointId,
cause);
}
+
+ protected void markCheckpointStart(long checkpointCreationTimestamp) {
+ latestCheckpointStartDelayNanos = 1000_000 * Math.max(
Review comment:
Offline discussion consensus was to:
- In order to have consistency start converging all of the metrics (when
adding new ones) to nano seconds. To nanoseconds instead of milliseconds,
because some metrics might need this extra precision
- Always adding the unit (`Nanos`) suffix to the metric name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
