rkhachatryan commented on a change in pull request #10939:
[FLINK-15750][network] Moving output flushing to the mailbox
URL: https://github.com/apache/flink/pull/10939#discussion_r370706740
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1451,7 +1485,9 @@ private void checkpointStreamOperator(StreamOperator<?>
op) throws Exception {
private static <OUT>
List<RecordWriter<SerializationDelegate<StreamRecord<OUT>>>>
createRecordWriters(
StreamConfig configuration,
- Environment environment) {
+ Environment environment,
+ OutputFlusher.OutputFlushers outputFlushers,
Review comment:
nit: this method could create immutable flushers and return them, instead of
receiving and passing
through the call chain. This would make it easier to reason about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
