rkhachatryan commented on a change in pull request #10939:
[FLINK-15750][network] Moving output flushing to the mailbox
URL: https://github.com/apache/flink/pull/10939#discussion_r370688709
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/LongRecordWriterThread.java
##########
@@ -63,46 +73,65 @@ public synchronized void shutdown() {
* @param records
* number of records to send
*/
- public synchronized void setRecordsToSend(long records) {
- checkState(!recordsToSend.isDone());
- recordsToSend.complete(records);
+ public void setRecordsToSend(long records) {
+ mailboxExecutor.execute(() ->
resumeAndSetRecordsToSend(records), "resumeAndSetRecordsToSend");
Review comment:
Is the check missing now?
(multiple calls here overwrite previous values and potentially lead to wrong
results)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
